Skip to content

Support retrieving available SKUs via /applications/{application.id}/skus #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rainbowdashlabs
Copy link

@rainbowdashlabs rainbowdashlabs commented Apr 15, 2025

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: #2827

Description

Adds the ability to retrieve available SKUs via the /applications/{application.id}/skus endpoint.
Adds mapping for SKU as an extension for the SkuSnowflake

@rainbowdashlabs rainbowdashlabs marked this pull request as ready for review April 15, 2025 13:33
@MinnDevelopment
Copy link
Member

I would like to wait for the open api spec to include this endpoint before merging.

See discord/discord-api-spec#37 (comment)

Copy link
Member

@MinnDevelopment MinnDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution :)

You need to add a few missing annotations to pass the compliance test, though.

@rainbowdashlabs
Copy link
Author

I would like to wait for the open api spec to include this endpoint before merging.

See discord/discord-api-spec#37 (comment)

Looking at the issue, is there any hope this will happen in the near future? It's open for over a year and there is no clear plan from discords site to add the openapi spec. I think that's a rather important endpoint for users that want to monetize their apps. Since discord has documentation for it, simply pushing this out might be the better option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants