Skip to content

Support retrieving available SKUs via /applications/{application.id}/skus#2828

Merged
MinnDevelopment merged 11 commits into
discord-jda:masterfrom
rainbowdashlabs:feature/skus-list
Dec 28, 2025
Merged

Support retrieving available SKUs via /applications/{application.id}/skus#2828
MinnDevelopment merged 11 commits into
discord-jda:masterfrom
rainbowdashlabs:feature/skus-list

Conversation

@rainbowdashlabs

@rainbowdashlabs rainbowdashlabs commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: #2827

Description

Adds the ability to retrieve available SKUs via the /applications/{application.id}/skus endpoint.
Adds mapping for SKU as an extension for the SkuSnowflake

@rainbowdashlabs rainbowdashlabs marked this pull request as ready for review April 15, 2025 13:33
@MinnDevelopment

Copy link
Copy Markdown
Member

I would like to wait for the open api spec to include this endpoint before merging.

See discord/discord-api-spec#37 (comment)

@MinnDevelopment MinnDevelopment left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution :)

You need to add a few missing annotations to pass the compliance test, though.

Comment thread src/main/java/net/dv8tion/jda/api/JDA.java Outdated
Comment thread src/main/java/net/dv8tion/jda/api/entities/SKUType.java Outdated
Comment thread src/main/java/net/dv8tion/jda/api/entities/SKUType.java Outdated
Comment thread src/main/java/net/dv8tion/jda/api/entities/SKUType.java Outdated
Comment thread src/main/java/net/dv8tion/jda/internal/entities/SKUImpl.java Outdated
@rainbowdashlabs

Copy link
Copy Markdown
Contributor Author

I would like to wait for the open api spec to include this endpoint before merging.

See discord/discord-api-spec#37 (comment)

Looking at the issue, is there any hope this will happen in the near future? It's open for over a year and there is no clear plan from discords site to add the openapi spec. I think that's a rather important endpoint for users that want to monetize their apps. Since discord has documentation for it, simply pushing this out might be the better option.

@rainbowdashlabs

Copy link
Copy Markdown
Contributor Author

Any chance this will get merged in the near future?

@freya022

freya022 commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

I doubt it will be before Components V2 gets merged unfortunately

@rainbowdashlabs

Copy link
Copy Markdown
Contributor Author

Rebased on current master. Yet no signs of life from discords openapi team.

Comment thread src/main/java/net/dv8tion/jda/api/entities/SKUFlag.java
Comment thread src/main/java/net/dv8tion/jda/api/entities/SKUFlag.java
Comment thread src/main/java/net/dv8tion/jda/api/entities/SKUFlag.java
Comment thread src/main/java/net/dv8tion/jda/internal/entities/SKUImpl.java Outdated
@MinnDevelopment

Copy link
Copy Markdown
Member

@rainbowdashlabs I went ahead and ran ./gradlew format on this to use the new formatter. If you can fix those last few review comments, we can integrate this in the next feature release.

@MinnDevelopment MinnDevelopment added this pull request to the merge queue Dec 28, 2025
Merged via the queue into discord-jda:master with commit 1fe21dc Dec 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants