Skip to content

Add support for user primary guilds#2863

Merged
MinnDevelopment merged 8 commits into
discord-jda:masterfrom
mjezek-dev:feat/primary-guild
Aug 23, 2025
Merged

Add support for user primary guilds#2863
MinnDevelopment merged 8 commits into
discord-jda:masterfrom
mjezek-dev:feat/primary-guild

Conversation

@mjezek-dev

Copy link
Copy Markdown
Contributor

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

Adds support for user primary guilds.

@mjezek-dev mjezek-dev marked this pull request as ready for review July 6, 2025 17:39
@Chew

Chew commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

This seems to have a mix of tab and 4 space indention, please make sure it's consistently 4 spaces

@aveCard1nal

Copy link
Copy Markdown

May I also suggest adding:

List<Member> Guild#getMembersByPrimaryGuild()
RestAction<List<Member>> Guild#retrieveMembersByPrimaryGuild()

This could be useful for cases where bots need to identify members who selected the guild as their primary. For example, to assign roles, highlight core members, or provide exclusive features.

@mjezek-dev

Copy link
Copy Markdown
Contributor Author

You could use Guild#findMembers with filter checking for member's primary guild to retrieve this info. Discord API doesn't directly support searching for members based on their primary guild like that is being done with usernames. Looking for cached members can be done just by iterating over list of all cached members from Guild#getMembers and checking for required primary guild, so I don't think it's needed to add specific method for this.

Comment thread src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java Outdated
Comment thread src/main/java/net/dv8tion/jda/api/entities/User.java Outdated
Comment thread src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java Outdated
@FigT

FigT commented Aug 22, 2025

Copy link
Copy Markdown

Hey! Is there anything blocking this PR? This would be useful :}

Comment thread src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java Outdated
Co-authored-by: Florian Spieß <business@minn.dev>
@MinnDevelopment MinnDevelopment merged commit 63a2abe into discord-jda:master Aug 23, 2025
1 check passed
@mjezek-dev mjezek-dev deleted the feat/primary-guild branch August 23, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants