Open
Conversation
Closed
Member
|
The idea for an unknown entity type is good for when discord initially releases new entity types, people running older version don't have to update to fix breaking changes. I think we should have different types of unknown channels ex: SocketUnknownVoiceChannel, SocketUnknownTextChannel, etc or have a generalized SocketUnknownChannel with just the id. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another way of resolving, partially, the issue with Threads.
It has a lot less changes than the other ( #1901 ), but with the disavantage that nothing will apparently break for who's using Discord.Net.
This solution adds a new channel type,
SocketUnknownChannel, that inherits from aISocketMessageChannelso making it easy to do basic functionality (send messages, files, get messages, etc), but has the drawback that now theNameproperty could benull, as the only information received about it is the id.So while it would fix the issue of not being able to process messages without a cached channel, it might cause a few unexpected issues for the developer, also by adding the possibility of a third type of "basic" channel (private, guild, unknown).
I still need to check the structure for the parsers and attributes to see if they are still working as expected.
Possible changes
SocketUnknownChanneltoSocketUnknownMessageChannelChanges
SocketUnknownChannelThis channel might be present inside message objects returned by the events MessageReceived and MessageUpdated.