Add embed parameter for webhooks in SendMessageAsync#2893
Open
akaJuliaan wants to merge 2 commits intodiscord-net:devfrom
Open
Add embed parameter for webhooks in SendMessageAsync#2893akaJuliaan wants to merge 2 commits intodiscord-net:devfrom
akaJuliaan wants to merge 2 commits intodiscord-net:devfrom
Conversation
Contributor
Author
|
The build for the samples logically fails because the new parameter does not yet exist in version 3.13.1 which they are referring to. |
Contributor
|
Embed parameter is not needed as you can pass a single embed in an embed array into the embeds parameter. Yes it's inconvenient but redundant parameters aren't useful |
Contributor
Author
|
If redundant parameters are unwanted, why is there the exactly same |
Contributor
|
Because removing it would be a breaking change.
…On Thu, Mar 28, 2024, 1:51 PM Julian ***@***.***> wrote:
If redundant parameters are unwanted, why is there the exactly same embed
parameter for the channels?
—
Reply to this email directly, view it on GitHub
<#2893 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOJF23A4RMRVSVJ6FUPDLS3Y2RC7TAVCNFSM6AAAAABFNEOUQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRVG44TCNJZGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
embedparameter to theSendMessageAsyncmethod for Webhooks, like it is already in theSendMessageAsyncmethod for Channels.Changes
embedparameter