Audio and voice client support#10
Conversation
FiniteReality
changed the title
|
This should be ready for review now. Please let me know where I've made mistakes with allocations and the like - it would be great if we could reduce the amount of allocations to as low as possible here. |
|
|
||
| public async Task SendAsync(uint ssrc, ushort sequence, uint samplePosition, ArraySegment<byte> audio, Memory<byte> secret, IPEndPoint endpoint = null) | ||
| { | ||
| // TODO: this only supports xsalsa20_poly1305_lite - should we support more? |
There was a problem hiding this comment.
What other formats are there?
There was a problem hiding this comment.
The only two others I know of are xsalsa20_poly1305 and xsalsa20_poly1305_suffix.
There was a problem hiding this comment.
You should support all 3 because IIRC not all voice servers support the new ones.
Thankfully this is mostly trivial.
|
I forgot to ask; should I implement voice receive in this PR, too? I'll apply the requested changes in a moment after I've finished some college assignments. 😛 EDIT: We discussed this on Discord, you said voice receive should be another PR |
|
@RogueException Any updates on this? |
3 participants
Opening this now for review and feedback. Right now, only the low-level clients are implemented, and UDP transmission/receiving is not complete.
Where possible, I tried to follow the approaches used elsewhere in Wumpus.Net. However, I came into some barriers:
In 3000445, I added voice send - though it is broken at the moment. I've compared packets and implementations between other libraries/bots, but I can't seem to notice any obvious difference so I'm not entirely sure what I've done wrong.This has since been fixed, and was a simple error on my part.