Skip to content

Comments

Update german.dm#8531

Open
Smokingsquirrel wants to merge 6 commits intodiscordia-space:masterfrom
Smokingsquirrel:german-coherence-update
Open

Update german.dm#8531
Smokingsquirrel wants to merge 6 commits intodiscordia-space:masterfrom
Smokingsquirrel:german-coherence-update

Conversation

@Smokingsquirrel
Copy link
Contributor

@Smokingsquirrel Smokingsquirrel commented Oct 23, 2024

About The Pull Request

Adds more filler words to the german language to make the reading experience more easy and better when someone speaks german. When I made this, my first code contribution for SS13, I had no eye for proper quality.

Why It's Good For The Game

Someone speaking german floods the chat with a lot of nouns and capitalized words and its looks and reads very bad, this amends that a little bit.

Testing

Built the environment and spoke around in it, I dont know what else to test.
It's also live on Soj and Iskhod and the new words showed up.

Changelog

🆑
add: more german filler words for the language
/:cl:

@Firefox13
Copy link
Contributor

Where's the testing part? Do the special symbols work?

@Smokingsquirrel
Copy link
Contributor Author

Smokingsquirrel commented Oct 24, 2024

Where's the testing part? Do the special symbols work?

Fuck you’re right, they did not. Will fix that, didn’t test every single word.

@Humonitarian
Copy link
Contributor

Waiting for testing section

@Smokingsquirrel
Copy link
Contributor Author

Waiting for testing section

Will add once I survived this pneumonia I have currently.

@Smokingsquirrel
Copy link
Contributor Author

Waiting for testing section

So it works, but I dont know what or how you want me to add anything that shows "yeah that works"

@SirRichardFrancis
Copy link
Member

SirRichardFrancis commented Dec 4, 2024

So it works, but I dont know what or how you want me to add anything that shows "yeah that works"

Fill out and append this section to the PR description:

## Testing

<!-- Describe the tests you ran with your addition. It is recommended to add images, videos and step-by-step explanations of conducted testing. -->

It is present when you create a PR and is not to be discarded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants