-
Notifications
You must be signed in to change notification settings - Fork 509
Mining Hotfixes + Balance Pass #8569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
VmpOS2NHSkhkejA9
wants to merge
57
commits into
discordia-space:master
from
VmpOS2NHSkhkejA9:golem-enhancements
Closed
Mining Hotfixes + Balance Pass #8569
VmpOS2NHSkhkejA9
wants to merge
57
commits into
discordia-space:master
from
VmpOS2NHSkhkejA9:golem-enhancements
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should not have taken me 4 hours but it did so here we are.
there's still an issue where they'll stay locked onto their target permanently once they charge.
still need to test coal!!!
limited CPU and its consequences on the human race
it knocks players out in only a few shots- it's disproportionately strong for the level it's introduced at.
i forgot to commit and then i made another change and then i was like "oh one more change" and i still didn't commit and now here we are
map changes jumpscare
- Remove tile-based resources and the noise datum that generates them. Nothing used them anyway. - Remove advanced ore detector, it only existed to detect the now-removed tile resources. - More KARL fixes - Add some description_info text to mining equipment to make it more clear what to do.
Co-authored-by: SirRichardFrancis <[email protected]>
…sma.dm Co-authored-by: SirRichardFrancis <[email protected]>
…sma.dm Co-authored-by: SirRichardFrancis <[email protected]>
…sma.dm Co-authored-by: SirRichardFrancis <[email protected]>
Co-authored-by: hyperioo <[email protected]>
Co-authored-by: hyperioo <[email protected]>
…jA9/CEV-Eris into golem-enhancements
Oh shit conflicts. Also should've opened a new branch for the 5 billion commits, but oh well. |
This PR should be considered "as-is". I no longer intend to contribute to this codebase; if any changes are requested the PR should instead be closed immediately |
SirRichardFrancis
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Feature:
Balance:
Fix:
attack_generic()
instead ofexplosion_act()
and thus properly respect structures being unbreakableget_golem_spawns()
start from 1 instead of 0 so that the intended number of golems spawn instead of way too many.Why It's Good For The Game
The game not being way more difficult than intended is good 👍
also bugfixes
Testing
Climbed an orebox.
Spawned a platinum golem, got gored slower than before.
Spawned a gold golem. Got skewered slower than before.
Opened a level 3 cave. Saw 4 golems spawn per squad, as intended.
Spawned a platinum golem. Hid behind an orebox. Orebox didn't get deleted.
Changelog
🆑
tweak: Ore boxes are climbable
balance: Platinum golems deal much less charge damage
balance: Gold golems deal much less spike damage
balance: Less golems spawn on seismic levels 3 & 4
balance: Coal and Iron golems are more common
fix: Correct number of golems spawn on all seismic levels. 1-3 less depending on seismic level.
fix: Platinum golems no longer bypass oreboxes being unbreakable
/:cl: