SQL Standardization And Qdel Update#8639
Open
vode-code wants to merge 2 commits intodiscordia-space:masterfrom
Open
SQL Standardization And Qdel Update#8639vode-code wants to merge 2 commits intodiscordia-space:masterfrom
vode-code wants to merge 2 commits intodiscordia-space:masterfrom
Conversation
used querying defineset to somewhat standardize queries and their deletion queries should now qdel after use bibledelay no longer uses spawn bibledelay message refactor removed some extra commas delayed_ban now a FireAndForget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR adds a set of defines and uses them to standardize the operation of our SQL. Additionally, library machine code was somewhat modernized, and we now delete our SQL datums once we're done using them.
Why It's Good For The Game
Apparently we don't have the right conditions for the garbage collection to grab SQL queries under the new system, so we gotta delete em ourselves- this change makes that easy. Additionally, Library Machine used Spawns for time-checks, which is better done as a time-memory check.
Testing
Launched game, joined as a character, nothing broke or runtimed. CI has the Mysql work as normal.