Added Route guildMembersSearchV2 for POST /guilds/{guild.id}/members-search#1307
Open
Lixqa wants to merge 2 commits intodiscordjs:mainfrom
Open
Added Route guildMembersSearchV2 for POST /guilds/{guild.id}/members-search#1307Lixqa wants to merge 2 commits intodiscordjs:mainfrom
Lixqa wants to merge 2 commits intodiscordjs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
This endpoint isn't documented on Discord's end right? If not, I'm torn on documenting it, and if we do, it MUST be documented with |
Author
|
No it isn't documented. It didn't even worked for bots like 3 months ago when I tested it last time. Seems like they enabled it for bots now. Maybe they are working on documenting it right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR adds support for the POST /guilds/{guild.id}/members-search route, which enables searching for guild members using a variety of query parameters - not just by nickname as with the older endpoint.
This is a preparatory step toward reworking GuildMemberManager#search() in discord.js to utilize this newer, more flexible route. By doing so, we can offer developers greater control and precision when searching for guild members.
The name of the route includes "V2", even if it's not ideal. This just follows the route naming 🤷♂️.
If applicable, please reference Discord API Docs PRs or commits that influenced this PR:
/