Skip to content
This repository was archived by the owner on Jan 8, 2022. It is now read-only.

refactor: rename attachment to file#98

Open
ckohen wants to merge 1 commit into
discordjs:mainfrom
ckohen:attachment-file
Open

refactor: rename attachment to file#98
ckohen wants to merge 1 commit into
discordjs:mainfrom
ckohen:attachment-file

Conversation

@ckohen
Copy link
Copy Markdown
Member

@ckohen ckohen commented Dec 30, 2021

Please describe the changes this PR makes and why it should be merged:

Discord and djs both use files to classify all attachments, we should follow suit.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 30, 2021

Codecov Report

Merging #98 (083148d) into main (9070440) will not change coverage.
The diff coverage is 87.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   88.82%   88.82%           
=======================================
  Files           9        9           
  Lines        1584     1584           
  Branches      167      167           
=======================================
  Hits         1407     1407           
  Misses         13       13           
  Partials      164      164           
Impacted Files Coverage Δ
packages/rest/src/lib/RequestManager.ts 93.09% <80.00%> (ø)
packages/rest/src/lib/REST.ts 95.57% <100.00%> (ø)
packages/rest/src/lib/errors/DiscordAPIError.ts 82.24% <100.00%> (ø)
packages/rest/src/lib/errors/HTTPError.ts 96.66% <100.00%> (ø)
...ackages/rest/src/lib/handlers/SequentialHandler.ts 82.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9070440...083148d. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants