refactor(GuildAuditLogsEntry)!: add type guard for narrowing #10521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Jiralite
reviewed
Oct 12, 2024
Qjuh
force-pushed
the
refactor/auditlogs-typings
branch
from
b547d2f to
941e8e1
Compare
Jiralite
changed the title
Jiralite
changed the title
vladfrangu
approved these changes
Nov 13, 2024
Jiralite
approved these changes
Nov 13, 2024
didinele
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds the
GuildAuditLogsEntry#isAction(action: AuditLogEvent)typeguard to narrow the entry's property types based on the action type.Before this it wasn't possible to narrow the target type or similar in
Client#guildAuditLogEntryCreateevent based on the actionType.Because
GuildAuditLogsEntryis a class and not a discriminated union this is the only way I could think of to achieve at least some sort of narrowing.In the process also cleaned up the typings a bit.
BREAKING CHANGE: removes
GuildAuditLogsEntry.Targets.Allwhich wasn’t used anywhere anywayStatus and versioning classification: