Skip to content

test: Fix builder methods in type test #10599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2024
Merged

test: Fix builder methods in type test #10599

merged 2 commits into from
Nov 17, 2024

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Nov 17, 2024 •
edited
Loading

Updates the builder methods to their correct name. Also removes an unused import.

@Jiralite Jiralite added the tests label Nov 17, 2024
@Jiralite Jiralite added this to the builders 2.0.0 milestone Nov 17, 2024
@Jiralite Jiralite requested a review from a team as a code owner November 17, 2024 10:08
@vercel Vercel
Copy link

vercel bot commented Nov 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Nov 17, 2024 10:25am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 17, 2024 10:25am

sdanialraza
sdanialraza requested changes Nov 17, 2024
View reviewed changes
Copy link
Member

@sdanialraza sdanialraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This outdated and unnecessary import can be removed as well

discord.js/packages/builders/__tests__/components/button.test.ts

Line 8 in b464ce6

import { ButtonBuilder } from '../../src/components/button/Button.js';

@Jiralite Jiralite requested a review from sdanialraza November 17, 2024 10:25
@kodiakhq kodiakhq bot merged commit 51a017a into main Nov 17, 2024
27 checks passed
@kodiakhq kodiakhq bot deleted the test/builder-types-fix branch November 17, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@didinele didinele didinele approved these changes

@sdanialraza sdanialraza sdanialraza approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/builders

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/builders

Assignees

No one assigned

Labels

packages:builders semver:patch tests

Projects

discord.js
Archived in project

Milestone

builders 2.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Jiralite @vladfrangu @SpaceEEC @didinele @sdanialraza