feat(Typing): cache member object #10786
Open
+7
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
vladfrangu
requested changes
Mar 1, 2025
Comment on lines
37
to
43
| if ('member' in data) { | ||
| /** | ||
| * The member that this guild typing instance represents | ||
| * @type {?GuildMember} | ||
| */ | ||
| this.member = this.channel.guild.members._add(data.member, true); | ||
| } |
There was a problem hiding this comment.
This PR makes the member only set when its provided, otherwise it will be undefined (not null). Either we keep the getter and add the caching logic in too, or we define a fallback that is the getter
There was a problem hiding this comment.
This can be done without getters. If the member property was not set when the object was created, then there can be no conditions when it will be set later (except manually). I can use the ternary operator to set null if there is no data.
What do you think?
There was a problem hiding this comment.
already adds the member to cache, so this is redundant. The getter was fine as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Discord API provides member object with
TYPING_STARTevent in guild. We can use this for cache update and getting value without getterStatus and versioning classification: