Skip to content

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Mar 6, 2025

Please describe the changes this PR makes and why it should be merged:
Embed thumbnails and images may use the attachment:// protocol. Icon URLs and footer icon URLs are currently fine as-is.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2025 8:17pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2025 8:17pm

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.15%. Comparing base (e273afb) to head (b25d01f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10795   +/-   ##
=======================================
  Coverage   39.15%   39.15%           
=======================================
  Files         244      244           
  Lines       14804    14804           
  Branches     1413     1413           
=======================================
  Hits         5796     5796           
  Misses       8996     8996           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Mar 7, 2025
@kodiakhq kodiakhq bot merged commit 12638cd into main Mar 7, 2025
8 checks passed
@kodiakhq kodiakhq bot deleted the fix/attachment-protocol branch March 7, 2025 20:19
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants