refactor: using eslint-config-neon on mainlib #10876
Open
+5,091
−3,370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
almeidx
requested changes
May 3, 2025
packages/discord.js/src/client/websocket/handlers/THREAD_LIST_SYNC.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/managers/ApplicationCommandPermissionsManager.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Almeida <[email protected]>
almeidx
requested changes
May 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10876 +/- ##
=======================================
Coverage 42.69% 42.69%
=======================================
Files 262 262
Lines 16099 16099
Branches 1548 1548
=======================================
Hits 6874 6874
Misses 9213 9213
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SpaceEEC
approved these changes
May 25, 2025
kyranet
approved these changes
May 25, 2025
vladfrangu
previously requested changes
May 25, 2025
Jiralite
requested changes
May 25, 2025
Co-authored-by: Jiralite <[email protected]>
Co-authored-by: Jiralite <[email protected]>
Jiralite
approved these changes
May 26, 2025
|
This file can be removed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Removes the old-style
.eslintrc.jsonand the custom configuration for mainlibdiscord.jsto instead use the globaleslint.config.jsusingeslint-config-neonstyle with only few of our customizations.This is semver minor because it moved the anonymousThe export of all methods offindNamefunction to the namedfindName()inUtil.jsand we export all methods from that file.Util.jshas been changed to only export a handpicked selection now, so no longer semver minor.Status and versioning classification: