Skip to content

feat: @discordjs/structures #10900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

feat: @discordjs/structures #10900

wants to merge 44 commits into from

Conversation

Qjuh
Copy link
Member

@Qjuh Qjuh commented May 16, 2025

Please describe the changes this PR makes and why it should be merged:

Supersedes #8417

Introduces a generic structure implementation for the main lib (and others) to build on.

TODO:

  • Application
  • Audit Log
  • Auto Moderation
  • Channel
    • Channels
    • Mixins
      • DM
      • Guild
      • Text
      •  Owner
      • Parent
      • Permissions
      • Pin
      •  Slowmode
      • Topic
      • Webhooks
      • Thread
      • ThreadOnly
      • Voice
    • Message
  • Emoji
  • Guild
    • Guild
    • Guild Preview
    • Guild Widget
    • Guild Member
    • Integration
    • Guild Ban
    • Membership Screening Oh wait...this is still undocumented
  • Guild Scheduled Event
  • Guild Template
  • Interactions (Need more thoughts on this)
  • Invite
  • Stage Instance
  • Sticker
    • Sticker
    • Sticker Pack
  • Teams
  • User
    • User
      • AvatarDecorationData
    • Connection
  • Voice
    • Voice State
    • Voice Region
  • Webhook

Status and versioning classification:

Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview May 25, 2025 4:08pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 25, 2025 4:08pm

Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 85.19528% with 163 lines in your changes missing coverage. Please review.

Project coverage is 60.47%. Comparing base (8605fc8) to head (c17f0cd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/structures/src/bitfields/BitField.ts 31.03% 60 Missing ⚠️
packages/structures/src/users/User.ts 37.68% 43 Missing ⚠️
packages/structures/src/users/Connection.ts 42.10% 22 Missing ⚠️
packages/structures/src/channels/Channel.ts 84.37% 10 Missing ⚠️
...es/structures/src/bitfields/PermissionsBitField.ts 63.63% 8 Missing ⚠️
packages/structures/src/Mixin.ts 96.03% 5 Missing ⚠️
packages/structures/src/utils/optimization.ts 16.66% 5 Missing ⚠️
...kages/structures/src/users/AvatarDecorationData.ts 63.63% 4 Missing ⚠️
packages/structures/src/Structure.ts 92.30% 2 Missing ⚠️
...ges/structures/src/channels/PermissionOverwrite.ts 96.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10900       +/-   ##
===========================================
+ Coverage   42.68%   60.47%   +17.78%     
===========================================
  Files         262      207       -55     
  Lines       16095    11804     -4291     
  Branches     1547     1636       +89     
===========================================
+ Hits         6870     7138      +268     
+ Misses       9213     4654     -4559     
  Partials       12       12               
Flag Coverage Δ
brokers 31.41% <ø> (ø)
builders 80.49% <ø> (ø)
collection 100.00% <ø> (ø)
core 0.89% <ø> (ø)
discord.js ?
formatters 99.63% <ø> (ø)
guide ?
next ?
proxy 65.88% <ø> (ø)
rest 86.47% <85.19%> (-1.29%) ⬇️
util 43.28% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 70.90% <ø> (ø)
website ?
ws 36.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Qjuh Qjuh marked this pull request as ready for review May 17, 2025 17:19
@Qjuh Qjuh requested review from a team and iCrawl as code owners May 17, 2025 17:19
@Qjuh Qjuh force-pushed the feat/structures branch from 14d3876 to d45807b Compare May 19, 2025 17:18
@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js May 19, 2025
@Qjuh Qjuh requested a review from almeidx May 20, 2025 15:29
@Qjuh Qjuh changed the title feat: structures feat: @discordjs/structures May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

3 participants