fix(Emoji): remove incorrect nullables, add ApplicationEmoji#available
#10913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Qjuh <[email protected]>
Co-authored-by: Qjuh <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
almeidx
changed the title
ApplicationEmoji#available
Qjuh
requested changes
May 26, 2025
Re-applies changes from #10613 Co-authored-by: Qjuh <[email protected]>
Qjuh
approved these changes
May 26, 2025
Jiralite
requested changes
May 26, 2025
Added by mistake in PR that used to target v14 Co-authored-by: Jiralite <[email protected]>
Co-authored-by: Jiralite <[email protected]>
…tions Co-authored-by: Jiralite <[email protected]>
Member
|
Please resolve conflicts! |
Jiralite
approved these changes
May 28, 2025
vladfrangu
approved these changes
May 30, 2025
github-project-automation
bot
moved this from Review in Progress
to Review Approved
in discord.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
ApplicationEmoji and BaseGuildEmoji inherit some incorrect nullables from Emoji (since they are never null for their case). Also BaseGuildEmoji#url wasn't marked as deprecated in the index.d.ts and ApplicationEmoji#available was missing (though always true, added for consistency with the rest). Internal discussion at https://discord.com/channels/222078108977594368/1366526457064591440/1366526457064591440
Supersedes #10905
Supersedes #10912
Fixes #10858
Specific (attempted) changes
Typings
| nullfromApplicationEmoji#author,managed, andrequiresColonsApplicationEmoji#managed's type tofalseandrequiresColonstotrueApplicationEmoji#available: trueApplicationEmoji#name,animated,imageURL,createdAtandcreatedTimestampto make them non nullableBaseGuildEmoji#name,animated, andmanagedto make them non nullable (the other properties were already non nullable)BaseGuildEmoji#urlandEmoji#urlsince those aren't present in runtime anymoreJS
ApplicationEmoji#name,animated,imageURL,createdAtandcreatedTimestamp's to remove the "or null if unicode" mentionsBaseGuildEmoji#name,animated,createdAtandcreatedTimestamp's to remove the "or null if unicode" mentions (imageURLalready has them)availableonApplicationEmoji:nullin constructor_patch()equals()Status and versioning classification: