Skip to content

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

  • Updated the documentation of RoleManager#fetch() to use colors
  • GuildMember#displayColor was always returning 0 as it referenced a non-existent property
  • Getting the hexColor of a role will cause a crash as this.color does not exist

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Jul 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Jul 20, 2025 0:12am
discord-js-guide ⬜️ Ignored (Inspect) Jul 20, 2025 0:12am

@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Jul 20, 2025
@Jiralite Jiralite changed the title fix(Role): Remove trailing color references fix: Remove trailing color references Jul 20, 2025
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does hexColor make sense to keep in its current form?

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Jul 20, 2025
@kodiakhq kodiakhq bot merged commit a7f711b into main Jul 20, 2025
10 checks passed
@kodiakhq kodiakhq bot deleted the fix/role-colours-missed branch July 20, 2025 12:26
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Jul 20, 2025
@almeidx
Copy link
Member

almeidx commented Jul 20, 2025

This is missing. And the typings do not correspond to the jsdoc / runtime implementation

color: color && resolveColor(color),

@Qjuh
Copy link
Member

Qjuh commented Jul 20, 2025

This is missing. And the typings do not correspond to the jsdoc / runtime implementation

color: color && resolveColor(color),

That's irrelevant as the route that uses is no longer available and errors either way.

Jiralite added a commit that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants