docs(voice): add DAVE dependency section#11061
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11061 +/- ##
===========================================
+ Coverage 32.45% 42.68% +10.23%
===========================================
Files 369 309 -60
Lines 13611 16566 +2955
Branches 1069 1657 +588
===========================================
+ Hits 4417 7071 +2654
- Misses 9059 9445 +386
+ Partials 135 50 -85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
📝 WalkthroughWalkthroughAdded a new subsection documenting DAVE Protocol Libraries for end-to-end encryption under the Encryption Libraries section of the package README, along with a warning note about Discord client requirements and a new dependency. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
packages/voice/README.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
packages/voice/README.md
65-65: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Tests
🔇 Additional comments (1)
packages/voice/README.md (1)
65-70: Content looks good, well-integrated into the dependencies section.The warning note clearly explains the requirement and the dependency listing is properly formatted. The addition fits naturally into the existing Documentation section structure and complements the previous Encryption Libraries section.
Please describe the changes this PR makes and why it should be merged:
Support for DAVE protocol was added at #10735
Discord mention this in a past blog post here and it seems like this is about to be a requirement.
As I discovered while I got repeated crashes due to discord not downgrading my connection to a non e2ee connection!
It could be very useful if i known about this dependency while searching for a solution.
It could be also a good idea to inform users in the release notes/changelog so they know it's a good idea to add this dependency.
Made another PR for the guide as well #11145
Status and versioning classification: