feat!: text display and other select menus for modal #11097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
BREAKING CHANGE: ModalSubmitInteraction#fields has been removed. BREAKING CHANGE: ModalSubmitInteraction#components is now ModalComponentResolver BREAKING CHANGE: ModalSubmitFields is no longer exported
imnaiyar
force-pushed
the
feat/model-selects
branch
from
fb86139 to
d5a00b9
Compare
Jiralite
force-pushed
the
feat/model-selects
branch
from
dd50af2 to
91d813b
Compare
Jiralite
reviewed
Sep 18, 2025
Jiralite
approved these changes
Sep 19, 2025
sdanialraza
approved these changes
Sep 20, 2025
vladfrangu
approved these changes
Sep 20, 2025
SpaceEEC
approved these changes
Sep 21, 2025
This was referenced Sep 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Resolves #11084
Requires:
BREAKING CHANGE:
ModalSubmitFieldsis no longer exportedBREAKING CHANGE:
ModalSubmitInteraction#fieldsis removedBREAKING CHANGE:
ModalSubmitInteraction#componentsis nowModalOptionResolverBREAKING CHANGE:
DjsErrorCodes#ModalSubmitInteractionFieldNotFound&DjsErrorCodes#ModalSubmitInteractionFieldTypeare now renamed toDjsErrorCodes#ModalSubmitInteractionComponentNotFound&DjsErrorCodes#ModalSubmitInteractionComponentTyperespectivelyStatus and versioning classification: