Skip to content

Conversation

Pavel-Boyazov
Copy link
Contributor

@Pavel-Boyazov Pavel-Boyazov commented Sep 29, 2025

Please describe the changes this PR makes and why it should be merged:
Function allow usage without rawData arg and has type, but in d.ts file it required and with unknown type

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Sep 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
discord-js-guide Ready Ready Preview Comment Oct 5, 2025 8:15pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Oct 5, 2025 8:15pm

@Pavel-Boyazov
Copy link
Contributor Author

I looked again at the code executed under the condition. What's the point of rawData anyway? The first condition does not require this parameter at all, the second and third can be replaced by the properties of the Message object

Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.23%. Comparing base (05224e7) to head (3ff8464).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11123      +/-   ##
==========================================
- Coverage   44.24%   44.23%   -0.02%     
==========================================
  Files         313      313              
  Lines       18039    18046       +7     
  Branches     1792     1792              
==========================================
+ Hits         7981     7982       +1     
- Misses      10046    10052       +6     
  Partials       12       12              
Flag Coverage Δ
brokers 26.29% <ø> (ø)
builders 79.59% <ø> (ø)
collection 100.00% <ø> (ø)
core 0.92% <ø> (ø)
formatters 99.65% <ø> (ø)
proxy 65.88% <ø> (ø)
rest 87.56% <ø> (ø)
structures 85.19% <ø> (ø)
util 43.28% <ø> (ø)
utilities 6.30% <ø> (ø)
voice 60.25% <ø> (-0.14%) ⬇️
ws 35.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants