Skip to content

Conversation

vladfrangu
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

image

Woopsy XD, forgot to add support for text displays in modal builder

Status and versioning classification:

@vladfrangu vladfrangu requested a review from a team as a code owner October 8, 2025 18:11
@vladfrangu vladfrangu requested review from iCrawl and removed request for a team October 8, 2025 18:11
Copy link

vercel bot commented Oct 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Oct 8, 2025 6:11pm
discord-js-guide Ignored Ignored Oct 8, 2025 6:11pm

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.66%. Comparing base (9a60e40) to head (282209d).
⚠️ Report is 1 commits behind head on builders/1.x.

Files with missing lines Patch % Lines
packages/builders/src/interactions/modals/Modal.ts 54.54% 10 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           builders/1.x   #11155      +/-   ##
================================================
+ Coverage         37.65%   37.66%   +0.01%     
================================================
  Files               240      240              
  Lines             15030    15050      +20     
  Branches           1346     1348       +2     
================================================
+ Hits               5659     5669      +10     
- Misses             9327     9337      +10     
  Partials             44       44              
Flag Coverage Δ
builders 88.35% <60.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Oct 8, 2025
@Jiralite Jiralite merged commit 99b8436 into builders/1.x Oct 8, 2025
27 checks passed
@Jiralite Jiralite deleted the fix/add-text-displays-in-modals-lol branch October 8, 2025 18:17
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants