Skip to content

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
An empty value may be set when not constrained by min_length.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
discord-js-guide Ready Ready Preview Comment Oct 16, 2025 1:54pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Oct 16, 2025 1:54pm

Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.19%. Comparing base (1a305fe) to head (9ff4106).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11182   +/-   ##
=======================================
  Coverage   44.19%   44.19%           
=======================================
  Files         313      313           
  Lines       18094    18094           
  Branches     1796     1796           
=======================================
  Hits         7996     7996           
  Misses      10086    10086           
  Partials       12       12           
Flag Coverage Δ
builders 79.59% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Oct 16, 2025
@kodiakhq kodiakhq bot merged commit 0cc92bd into main Oct 16, 2025
27 checks passed
@kodiakhq kodiakhq bot deleted the fix/text-value-empty branch October 16, 2025 13:55
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

TextInputBuilder#setValue() no longer allows empty strings, but Discord API does

4 participants