feat(structures): add guild and related structures#11394
feat(structures): add guild and related structures#11394keston-dev wants to merge 16 commits intodiscordjs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
keston-dev
changed the title
keston-dev
changed the title
|
To add a quick progress update (based on #10981):
|
keston-dev
requested review from
Qjuh,
almeidx,
ckohen,
iCrawl and
vladfrangu
packages/structures/src/guild/scheduled-event/GuildScheduledEvent.ts
Outdated
Show resolved
Hide resolved
packages/structures/src/guild/scheduled-event/GuildScheduledEvent.ts
Outdated
Show resolved
Hide resolved
packages/structures/src/guild/scheduled-event/GuildScheduledEventRecurrenceRuleNWeekday.ts
Outdated
Show resolved
Hide resolved
packages/structures/src/guild/scheduled-event/GuildScheduledEventRecurrenceRule.ts
Outdated
Show resolved
Hide resolved
packages/structures/src/guild/scheduled-event/GuildScheduledEvent.ts
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #11394 +/- ##
==========================================
- Coverage 31.62% 30.55% -1.07%
==========================================
Files 385 402 +17
Lines 13918 14451 +533
Branches 1096 1163 +67
==========================================
+ Hits 4401 4416 +15
- Misses 9383 9901 +518
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Qjuh
left a comment
Qjuh
left a comment
There was a problem hiding this comment.
Also still blocked until we make a definite decision about exposing arrays of primitive data types as getters as well as the proposed change to use createdDate naming conventions instead of the current createdAt (and any similar getters) to make the distinction of the returned data type more explicit.
| : null; | ||
| } | ||
|
|
||
| public get permissions() { |
There was a problem hiding this comment.
Missing JSDoc and this doesn't even use the correct symbol field. The one this uses will always be undefined because of DataTemplate omitting it.
| * | ||
| * @typeParam Omitted - Specify the properties that will not be stored in the raw data field as a union, implement via `DataTemplate` | ||
| * @remarks Intentionally does not export `channels`, or `members`, | ||
| * so extending classes can map each array to `GuildWidgetChannel[]`, and `GuildWidgetMember[]` respectively. |
There was a problem hiding this comment.
There are no such structures by that name. They would just be (partial) Channel and GuildMember structures, right?
| /** | ||
| * The time the guild scheduled event will start at. | ||
| */ | ||
| public get scheduledStartAt() { |
There was a problem hiding this comment.
| public get scheduledStartAt() { | |
| public get scheduledStartDate() { |
Just as a blocker to not get merged before changed everywhere
3 participants
This will add all
Guild-related API structures.As of this first post, only the
Guildstructure, and its necessary substructures,GuildWelcomeScreenandGuildIncidentsDatahave been created.Mentioning #10981 for visibility.