test(structures): add tests for several structures#11407
Draft
AsadHumayun wants to merge 38 commits intodiscordjs:mainfrom
Draft
test(structures): add tests for several structures#11407AsadHumayun wants to merge 38 commits intodiscordjs:mainfrom
AsadHumayun wants to merge 38 commits intodiscordjs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11407 +/- ##
==========================================
+ Coverage 31.61% 37.45% +5.84%
==========================================
Files 387 387
Lines 13995 14013 +18
Branches 1100 1104 +4
==========================================
+ Hits 4424 5249 +825
+ Misses 9437 8585 -852
- Partials 134 179 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AsadHumayun
force-pushed
the
feat/add-tests-several-structures
branch
from
9edce03 to
ac342cd
Compare
Qjuh
requested changes
Jan 28, 2026
Member
Qjuh
left a comment
Qjuh
left a comment
There was a problem hiding this comment.
Apart from these little nitpicks LGTM
Qjuh
reviewed
Jan 29, 2026
almeidx
reviewed
Jan 29, 2026
AsadHumayun
added a commit
to AsadHumayun/discord.js
that referenced
this pull request
Feb 27, 2026
When writing tests for discordjs#11407, it became apparent that I had forgotten to add the `toJSON` method for this structure when I was initially wrote the structure. I have now added this method and it passes when running the tests that I have written for this (which will be merged in a following PR). Signed-off-by: Asad Humayun <asad.humayun@asadh.io>
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 1, 2026
#11431) fix(structures): add missing `toJSON` method on Subscription When writing tests for #11407, it became apparent that I had forgotten to add the `toJSON` method for this structure when I was initially wrote the structure. I have now added this method and it passes when running the tests that I have written for this (which will be merged in a following PR). Signed-off-by: Asad Humayun <asad.humayun@asadh.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR currently adds tests for the following structures:
I intend on adding tests for more structures also to this PR (to help avoid the number of PRs in review).
Since #11406 will introduce URL getters for several structures, this PR will remain in draft until that is merged so that I can merge and add tests for those methods in one go (to help avoid additional PRs).
I have only added 2 tests for structures so far just so that I can get some initial feedback on the type of approach.