Skip to content

feat: modal radio group and checkbox components for v14#11437

Merged
Qjuh merged 2 commits intodiscordjs:v14from
imnaiyar:v14-checkbox-radiogroup
Mar 11, 2026
Merged

feat: modal radio group and checkbox components for v14#11437
Qjuh merged 2 commits intodiscordjs:v14from
imnaiyar:v14-checkbox-radiogroup

Conversation

@imnaiyar
Copy link
Contributor

@imnaiyar imnaiyar commented Mar 3, 2026 •
edited
Loading

I have only cherry-picked it, need to test if it works properly for v14 before marking it ready (though i imagine it should)

Backports #11395

@imnaiyar @almeidx
feat: modal radio group and checkbox components
d8dd858 
* feat: radio group and checkbox component in modal

* chore: some doc and type fixes

* chore: missing types

* chore: update component names

* docs: radio group value now returns null if not selected

* Remove empty line at the beginning of ModalSubmitInteraction.js

* Change value property to be nullable in RadioGroupModalData

* chore: review

* chore: missing "type"

* chore: suggestion

Co-authored-by: Almeida <github@almeidx.dev>

* chore: review

Co-authored-by: Almeida <github@almeidx.dev>

---------

Co-authored-by: Almeida <github@almeidx.dev>
@vercel
Copy link

vercel bot commented Mar 3, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
discord-js Error Error Mar 6, 2026 5:55pm
discord-js-guide Error Error Mar 6, 2026 5:55pm

Request Review

@Qjuh
Copy link
Member

Qjuh commented Mar 3, 2026

Reviewing this I was wondering whether v14 would need XComponent classes for the new modal components. But looking through where they get used I found out that they wouldn't be used anywhere because LabelComponent isn't used anywhere either, so probably not needed.

@imnaiyar
Copy link
Contributor Author

imnaiyar commented Mar 3, 2026

Reviewing this I was wondering whether v14 would need XComponent classes for the new modal components. But looking through where they get used I found out that they wouldn't be used anywhere because LabelComponent isn't used anywhere either, so probably not needed.

Yeah it doesn't get used anywhere, i raised this internally here https://discord.com/channels/222078108977594368/1402934237358985246/1412389550503891065 back when label component was introduced. The only reason i kept LabelComponent was because jiralite had some ideas on how we can use them in the future at the time (you'll have to scroll a bit though). I don't think any of that is needed anymore

@imnaiyar imnaiyar marked this pull request as ready for review March 6, 2026 17:56
@imnaiyar imnaiyar requested a review from a team as a code owner March 6, 2026 17:56
@imnaiyar imnaiyar requested review from SpaceEEC, iCrawl, kyranet and vladfrangu and removed request for a team March 6, 2026 17:56
@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Mar 6, 2026
@Qjuh Qjuh merged commit b42e499 into discordjs:v14 Mar 11, 2026
6 of 8 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Mar 11, 2026
@imnaiyar imnaiyar deleted the v14-checkbox-radiogroup branch March 11, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@Qjuh Qjuh Qjuh approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees

No one assigned

Labels

packages:discord.js

Projects

discord.js
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imnaiyar @Qjuh @vladfrangu