Skip to content

fix(voice): strip padding from packets and add guards #11449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 4 commits into from
Mar 13, 2026
+21 −1
Merged

fix(voice): strip padding from packets and add guards #11449

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
280ef44
fix(voice): strip padding from incoming packets
Snazzah Mar 12, 2026
2dad596
fix(voice): add additional guards to voice recieve
Snazzah Mar 12, 2026
58213b4
chore: apply comments
Snazzah Mar 13, 2026
3a8e00e
chore: fix formatting
Snazzah Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/voice/src/receive/VoiceReceiver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,15 @@ export class VoiceReceiver {
let packet: Buffer = this.decrypt(buffer, mode, nonce, secretKey);
if (!packet) throw new Error('Failed to parse packet');

// Strip padding (RFC3550 5.1)
const hasPadding = buffer[0] && Boolean(buffer[0] & 0b100000);
if (hasPadding) {
const paddingAmount = packet[packet.length - 1]!;
if (paddingAmount < packet.length) {
packet = packet.subarray(0, packet.length - paddingAmount);
}
}

// Strip decrypted RTP Header Extension if present
// The header is only indicated in the original data, so compare with buffer first
if (buffer.subarray(12, 14).compare(HEADER_EXTENSION_BYTE) === 0) {
Expand Down Expand Up @@ -176,6 +185,14 @@ export class VoiceReceiver {
if (!stream) return;

if (this.connectionData.encryptionMode && this.connectionData.nonceBuffer && this.connectionData.secretKey) {
// As a guard, we shouldn't parse packets that (1) aren't voice packets and (2) are not in the right RTP version
// 0x78 (120) is the default Opus payload type, the marker bit is (largely) unused here by Discord
if (msg[1] !== 0x78) return;

// Ignore packets not in RTP version 2
const rtpVersion = msg[0]! >> 6;
if (rtpVersion !== 2) return;

try {
const packet = this.parsePacket(
msg,
Expand Down
Loading