Skip to content

fix(core): webhook delete query type, removeMember await #11483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
almeidx wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Draft

fix(core): webhook delete query type, removeMember await #11483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/api/guild.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1237,7 +1237,7 @@ export class GuildsAPI {
userId: Snowflake,
{ auth, reason, signal }: Pick<RequestData, 'auth' | 'reason' | 'signal'> = {},
) {
return this.rest.delete(Routes.guildMember(guildId, userId), { auth, reason, signal });
await this.rest.delete(Routes.guildMember(guildId, userId), { auth, reason, signal });
}

/**
Expand Down
3 changes: 2 additions & 1 deletion packages/core/src/api/webhook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
type RESTPostAPIWebhookWithTokenQuery,
type RESTPostAPIWebhookWithTokenSlackQuery,
type RESTPostAPIWebhookWithTokenWaitResult,
type RESTDeleteAPIWebhookWithTokenMessageQuery,
type Snowflake,
} from 'discord-api-types/v10';

Expand Down Expand Up @@ -259,7 +260,7 @@ export class WebhooksAPI {
id: Snowflake,
token: string,
messageId: Snowflake,
query: { thread_id?: Snowflake } = {},
query: RESTDeleteAPIWebhookWithTokenMessageQuery = {},
{ signal }: Pick<RequestData, 'signal'> = {},
) {
await this.rest.delete(Routes.webhookMessage(id, token, messageId), {
Expand Down
Loading