feat: split CommandInteractionOptionResolver
#8439
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
SpaceEEC,
iCrawl,
kyranet and
vladfrangu
vladfrangu
previously requested changes
Aug 7, 2022
packages/discord.js/src/structures/ChatInputCommandInteractionOptionResolver.js
Outdated
Show resolved
Hide resolved
Member
|
I don't see how this split is correct? Why are the methods for subcommands, subcommand groups and the primitive types (string, number, integer, boolean) removed from the AutocompleteInteractionOptionResolver? They should all still work, as the value doesn't require any resolved structures. I thought the issue was only that Discord doesn't send resolved data for Users/GuildMembers, Roles and Channels in AutocompleteInteraction. Also this is 100% breaking. You changed the interface. |
This comment was marked as off-topic.
This comment was marked as off-topic.
MrMythicalYT
suggested changes
Oct 12, 2022
|
|
||
| /** | ||
| * The options passed to the command | ||
| * @type {CommandInteractionOptionResolver} |
Contributor
There was a problem hiding this comment.
Suggested change
| * @type {CommandInteractionOptionResolver} | |
| * @type {AutocompleteInteractionOptionResolver} |
|
|
||
| /** | ||
| * The options passed to the command. | ||
| * @type {CommandInteractionOptionResolver} |
Contributor
There was a problem hiding this comment.
Suggested change
| * @type {CommandInteractionOptionResolver} | |
| * @type {ChatInputCommandInteractionOptionResolver} |
| super(client, data); | ||
| /** | ||
| * The target of the interaction, parsed into options | ||
| * @type {CommandInteractionOptionResolver} |
Contributor
There was a problem hiding this comment.
Suggested change
| * @type {CommandInteractionOptionResolver} | |
| * @type {ContextMenuCommandInteractionOptionResolver} |
Member
|
No idea if this PR is still meant to be implemented.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR splits
CommandInteractionOptionResolverto make methods visible in the docs only what are available in the context.Status and versioning classification: