refactor: use .data property on all classes
#8856
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
SpaceEEC,
iCrawl,
kyranet and
vladfrangu
MrMythicalYT
changed the title
.data property.data property on all classes
kyranet
requested changes
Dec 12, 2022
Comment on lines
+107
to
109
| if (!this.data.name_localizations) { | ||
| this.data.name_localizations = {}; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (!this.data.name_localizations) { | |
| this.data.name_localizations = {}; | |
| } | |
| this.data.name_localizations ??= {}; |
There was a problem hiding this comment.
Although I'd argue that this should be done after the validation checks.
|
Closing in favour of #10448. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR makes the
SlashCommandBuilderandContextMenuCommandBuilderclasses use.dataStatus and versioning classification: