-
-
Notifications
You must be signed in to change notification settings - Fork 4k
feat: @discordjs/redis-gateway #9541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
didinele
wants to merge
12
commits into
main
Choose a base branch
from
feat/discord-redis-gateway
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
53c4847
chore: init package
didinele 5ce966a
chore: dockerfile and ci
didinele f7d8aa6
chore(core): document gateway
didinele cf58097
feat: redis gateway
didinele 0be62db
chore: additional readme mention
didinele 87dee70
chore: nits
didinele 66497f1
refactor(core): allow easily supporting redis gateway
didinele cc2bc79
chore: include core team to codeowners
didinele 4444ca6
chore: fix typo
didinele 2448062
chore: fix readme example
didinele 92bc6d8
chore: doc mistakes
didinele d2c7c90
docs: constructor param in the wrong place
didinele File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import type { PubSubRedisBroker } from '@discordjs/brokers'; | ||
import type { ManagerShardEventsMap, WebSocketShardEvents } from '@discordjs/ws'; | ||
import { AsyncEventEmitter } from '@vladfrangu/async_event_emitter'; | ||
import type { GatewaySendPayload, GatewayDispatchEvents } from 'discord-api-types/v10'; | ||
import type { DiscordEvents } from '../client.js'; | ||
import type { Gateway } from './Gateway.js'; | ||
|
||
interface BrokerIntrinsicProps { | ||
shardId: number; | ||
} | ||
|
||
interface Events extends DiscordEvents { | ||
gateway_send: GatewaySendPayload; | ||
} | ||
|
||
export type RedisBrokerDiscordEvents = { | ||
[K in keyof Events]: BrokerIntrinsicProps & { payload: Events[K] }; | ||
}; | ||
|
||
export class RedisGateway | ||
extends AsyncEventEmitter<{ dispatch: ManagerShardEventsMap[WebSocketShardEvents.Dispatch] }> | ||
implements Gateway | ||
{ | ||
public constructor( | ||
private readonly broker: PubSubRedisBroker<RedisBrokerDiscordEvents>, | ||
private readonly shardCount: number, | ||
) { | ||
super(); | ||
} | ||
|
||
public getShardCount(): number { | ||
return this.shardCount; | ||
} | ||
|
||
public async send(shardId: number, payload: GatewaySendPayload): Promise<void> { | ||
await this.broker.publish('gateway_send', { payload, shardId }); | ||
} | ||
|
||
public async init(group: string, events: GatewayDispatchEvents[]) { | ||
for (const event of events) { | ||
this.broker.on(event, ({ data: { payload, shardId }, ack }) => { | ||
// @ts-expect-error - Union shenanigans | ||
this.emit('dispatch', { shardId, data: payload }); | ||
void ack(); | ||
}); | ||
} | ||
|
||
await this.broker.subscribe(group, events); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,4 @@ | ||
{ | ||
"extends": "../../tsconfig.json", | ||
"compilerOptions": { | ||
"skipLibCheck": true | ||
}, | ||
"include": ["src/**/*.ts"] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.