Conversation
amishshah
left a comment
amishshah
left a comment
There was a problem hiding this comment.
I looked mainly at the @discordjs/voice-specific code but that looks good to me so far 🚀
| try { | ||
| await entersState(this.voiceConnection, VoiceConnectionStatus.Ready, 20_000); | ||
| } catch { | ||
| if (this.voiceConnection.state.status !== VoiceConnectionStatus.Destroyed) { | ||
| this.voiceConnection.destroy(); | ||
| } | ||
| } finally { | ||
| this.readyLock = false; | ||
| } |
There was a problem hiding this comment.
We need to remember to change this at some point, because at the moment it prevents a 5 rejoin attempt limit and replaces it with a 20 second hard cap.
|
There's a few issues with this. While an interesting concept, Just my take. |
This comment has been minimized.
This comment has been minimized.
iCrawl
force-pushed
the
feat/first-mvp
branch
4 times, most recently
from
f3e3a86 to
5c92a14
Compare
kyranet
left a comment
kyranet
left a comment
There was a problem hiding this comment.
This plus @amishshah's review 19 days ago.
| const clientId = req.params.clientId; | ||
| const guildId = req.params.guildId; |
There was a problem hiding this comment.
Why not something like this?
| const clientId = req.params.clientId; | |
| const guildId = req.params.guildId; | |
| const { clientId, guildId } = req.params; |
| // @ts-ignore | ||
| const { entries } = await youtubedl(`ytsearch10:${search}`, { dumpSingleJson: '' }); |
There was a problem hiding this comment.
Why is it ignored? What's the 10 in the search? Is it not possible to search in SoundCloud as well like Lavalink does?
There was a problem hiding this comment.
- The types are wrong/don't support
dumpSingleJson. nrefers to the number of results wanted.- Probably could, but I wanted to avoid the user doing
ytsearchNthemselves, so there needs to be a nicer way to handle this then.
6 participants
No description provided.