DEV: Add the ability to translate a single piece of text #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyb-talks
reviewed
Apr 22, 2025
| def self.required_settings_enabled | ||
| SiteSetting.translator_enabled && SiteSetting.translator_provider == "DiscourseAi" && | ||
| SiteSetting.discourse_ai_enabled && SiteSetting.ai_helper_enabled | ||
| def self.required_settings_enabled! |
There was a problem hiding this comment.
naming nit: I was wondering if something like validate_required_settings might be clearer.. when I read these, my initial thought was that this method was modifying stuff because of the !.
tyb-talks
approved these changes
Apr 22, 2025
I believe you're mistaken because |
nattsw
added a commit
that referenced
this pull request
Apr 24, 2025
This feature introduces the ability to translate categories on core's CategoryLocalization from discourse/discourse#32380. This includes - the addition of a generic `Translator.translate` which takes in supported models - a `CategoryTranslator` specific to categories, which uses the basic text translator introduced in #281 - a 12-hourly scheduled job that invokes a regular job. Anyone can manually translate all categories using ``` Jobs.enqueue(:translate_categories) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the translator providers are all implementing a
translate!that takes in a model (post or topic). We want to add a generatetranslate_textmethod that allows us to just say "Translate '日本' to English"Note that since we omit the source language, this new method is unsupported on Libre and Yandex.