Skip to content

Conversation

@Alexander-Cairns
Copy link
Contributor

No description provided.

Copy link
Contributor

@adam-vessey adam-vessey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine if we want to do it this way; however, it also appears to be possible to specify configuration via environment variables: https://cantaloupe-project.github.io/manual/5.0/configuration.html#EnvironmentConfiguration

... so could equally relatively easily pass things in the helm charts, if desired?

@Alexander-Cairns Alexander-Cairns added the minor Added functionality that is backwards compatible. label Feb 7, 2025
@Alexander-Cairns
Copy link
Contributor Author

Fine if we want to do it this way; however, it also appears to be possible to specify configuration via environment variables: https://cantaloupe-project.github.io/manual/5.0/configuration.html#EnvironmentConfiguration

... so could equally relatively easily pass things in the helm charts, if desired?

I don't have a strong preference either way.

@adam-vessey
Copy link
Contributor

Fine if we want to do it this way; however, it also appears to be possible to specify configuration via environment variables: https://cantaloupe-project.github.io/manual/5.0/configuration.html#EnvironmentConfiguration
... so could equally relatively easily pass things in the helm charts, if desired?

I don't have a strong preference either way.

Same. That said, if we went ahead and defined a HEALTHCHECK bit in the Dockerfile, then it would more definitively suggest putting things into this repo. Though the given HEALTHCHECK thing wouldn't be used by k8s, it could still potentially be useful for ddev/docker compose things? ramble

@adam-vessey adam-vessey merged commit 82b23ec into main Feb 11, 2025
2 checks passed
@adam-vessey adam-vessey deleted the FDSF-131 branch February 11, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Added functionality that is backwards compatible.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants