-
Notifications
You must be signed in to change notification settings - Fork 0
FDSF-262: Adjust build process to target version. #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The branch has gotten another release; however, we are not yet ready to move up to it (it's being tracked elsewhere).
WalkthroughThe Dockerfile has been updated to remove the Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant Docker as Docker Build Process
participant Repo as Cantaloupe Repository
Dev->>Docker: Build with ARG CANTALOUPE_VERSION
Docker->>Repo: ADD repository with version tag
Repo-->>Docker: Repository content received
Docker->>Docker: Set WORKDIR to /build/cantaloupe
Poem
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🪛 Hadolint (2.12.0)Dockerfile[error] 37-37: Use COPY instead of ADD for files and folders (DL3020) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The branch has gotten another release; however, we are not yet ready to move up to it (it's being tracked elsewhere, i.e.: #17 ).
Building against discoverygarden/cantaloupe_configs#19 , with something like:
docker build --build-arg CANTALOUPE_CONFIGS_VERSION=feature/redirect-header-control -t 358734507516.dkr.ecr.us-east-1.amazonaws.com/cantaloupe:fdsf-262 --push --platform=linux/arm64,linux/amd64 .Summary by CodeRabbit