-
Notifications
You must be signed in to change notification settings - Fork 5
Add category for DGI image discovery field type #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a new field type category configuration, updates the DIDImageItem field type plugin annotation to use that category, and bumps the module core_version_requirement; no executable code or API signatures were changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
dgi_image_discovery.field_type_categories.yml(1 hunks)src/Plugin/Field/FieldType/DIDImageItem.php(1 hunks)
🔇 Additional comments (3)
dgi_image_discovery.field_type_categories.yml (1)
1-4: Category config looks correct and matches the plugin annotation ID.Label/description/weight are sensible. No functional concerns.
src/Plugin/Field/FieldType/DIDImageItem.php (2)
15-23: Good addition: FieldType categorized for Field UI.
category = "dgi_image_discovery"correctly aligns with the new category ID.
21-21: Guard against older-core breakage.The "category" key isn’t recognized by older Drupal versions and could trigger an annotation exception. Ensure your supported core range excludes unsupported versions (update core_version_requirement if necessary).
If updating, add to your .info.yml:
core_version_requirement: ^10.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
dgi_image_discovery.info.yml (1)
5-5: Confirm necessity of ^10.2 and consider widening to Drupal 11.If the new field type category requires APIs introduced in Drupal 10.2, this bump is justified. If the module also runs on Drupal 11, widen the constraint to avoid blocking adopters.
Proposed change:
-core_version_requirement: ^10.2 +core_version_requirement: ^10.2 || ^11
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
dgi_image_discovery.info.yml(1 hunks)
|
This seems to promote/support the idea of adding a separate copy of this computed field beyond the base field we inject, but this should really never be necessary? #38 makes things go away more completely. |
While creating fields, the DGI Image Discovery field appears as Taxonomy Term.
Re: https://islandora.slack.com/archives/CM5PPAV28/p1756247387293879
Summary by CodeRabbit
New Features
Chores