-
Notifications
You must be signed in to change notification settings - Fork 0
FDSF4-229: Support solr cloud #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughUpdates GitHub Actions workflows: add packages: write permission, extend branch triggers, enable manual dispatch with env input, and bump reusable workflow to v2. Dockerfile gains TARGETOS and YQ_VERSION args, introduces SOLR_INSTALL env, updates HOCR plugin path, and installs yq binaries using TARGETOS/TARGETARCH. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub Actions
participant Reuse as Reusable WF (v2)
participant Reg as Container Registry
Dev->>GH: Push tag / PR to main or v2
GH->>GH: Evaluate triggers and permissions (packages: write)
GH->>Reuse: Invoke build-image workflow @v2
Reuse->>Reg: Authenticate and push image (needs packages: write)
Reuse-->>GH: Report status
sequenceDiagram
autonumber
actor Ops as Operator
participant GH as GitHub Actions
participant Rebuild as Rebuild WF (v2)
participant Reg as Container Registry
Ops->>GH: workflow_dispatch (env: dev|prod, default prod)
GH->>Rebuild: Run with inputs and image-name = vars.DOCKER_IMAGE_NAME
Rebuild->>Reg: Build and push image (packages: write)
Rebuild-->>GH: Completion status
sequenceDiagram
autonumber
participant Build as Docker Build
participant Net as Network
participant FS as Filesystem
Build->>Build: ARG TARGETOS, TARGETARCH, YQ_VERSION
Build->>Net: Download yq for TARGETOS/TARGETARCH
Net-->>FS: yq binary
Build->>FS: Install /usr/local/bin/yq
Build->>Build: ENV SOLR_INSTALL=/opt/solr
Build->>Build: Set SOLR_HOCR_PLUGIN_PATH=${SOLR_INSTALL}/contrib/ocrhighlighting/lib
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
adam-vessey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer really reflects expectations from discoverygarden/solr-image#15
Should possibly be something like the full ${solr.hocr.plugin.path:/opt/solr_extra_lib/ocrhighlighting/lib} bit, without interpolating ('til Solr makes use of things, anyway).
Fixed 569f250 |
Summary by CodeRabbit