DGI9-479 : Adding empty check on csl type.

[MorganDawe]

Summary by CodeRabbit

• Bug Fixes
  • Made form selection more resilient when the default CSL type is missing or empty—now falls back to an empty string to avoid notices/errors while preserving prior rendering behavior.

[coderabbitai]

Walkthrough

The assignment of blockCSLType in SelectCslForm.php was changed to use the null coalescing operator, defaulting to an empty string if default_csl_type is not set in $settings. This avoids undefined index errors and keeps the value as a string with no functional behavior changes.

Changes

Cohort / File(s)	Summary
CSL Form Logic src/Form/SelectCslForm.php	Changed blockCSLType assignment to use $settings['default_csl_type'] ?? "", ensuring a string default value rather than potentially undefined or null. Removed previous direct assignment without fallback.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Review the null coalescing usage to confirm it safely replaces the previous direct assignment.
• Verify no code expects blockCSLType to be null or undefined since now it defaults to an empty string.
• Confirm that no additional behavioral changes occur beyond the safeguard against missing key errors.

Poem

🐇 A little tweak, no cause for fear,
When defaults hide, an empty string's near,
No errors now where blanks used to creep,
Our code now hops on, steady and neat,
A gentle change, with care sincere!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'DGI9-479 : Adding empty check on csl type.' accurately describes the main change: adding a null coalescing operator (??) to handle cases where the default CSL type is not set, preventing potential errors.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch DGI9-479

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 72c2e27 and d303cc9.

📒 Files selected for processing (1)

• src/Form/SelectCslForm.php (1 hunks)

🔇 Additional comments (1)

src/Form/SelectCslForm.php (1)

115-115: Previous critical issue resolved – LGTM!

The null coalescing operator correctly ensures $this->blockCSLType is always a string (empty string when the key is missing or null, actual value otherwise). This addresses the previous critical logic error and aligns with the property's @var string declaration at line 31.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 39391bb and 72c2e27.

📒 Files selected for processing (1)

• src/Form/SelectCslForm.php (1 hunks)