FAT32: add functions to get File cluster chain and disk areas #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deitch
requested changes
Dec 3, 2024
Collaborator
deitch
left a comment
deitch
left a comment
There was a problem hiding this comment.
Looks good to me, and I appreciate the description of the use cases. Maybe add those to the docs (even just the inline), so someone looking at this in 6 or 12 months and wonders why we would expose such details, can see?
Also there is a linting error.
Contributor
Author
|
sorry for the delay, added the use cases to the inline docs and fixed the linter errors now |
deitch
approved these changes
Dec 9, 2024
Collaborator
|
No problem. Thanks for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some low-level filesystem operations it can be beneficial to both get the cluster chain of a given file as well as querying where exactly on disk the file contents reside.
Examples where such info might be useful:
This PR adds two functions, one to just expose the internal getClustersList via the File type.
The other to express the same info directly in disk areas, where each area is described by its starting byte and a length in bytes. (further conversion to disk sectors / LBA can be easily performed by the caller.)