fix(filesystem/iso9660): fix bug when compare null bytes #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Would you please update the description as to why this is necessary? When does the slice given by |
deitch
requested changes
Feb 4, 2021
Collaborator
deitch
left a comment
deitch
left a comment
There was a problem hiding this comment.
In addition to the comment in the PR, please:
- create a single var of alternate nullBytes and compare it, rather than building each time, something like:
nullBytesAlt := bytes.Repeat([]byte{0}, len(nullBytes))and then use that in thebytes.Compare - describe in a comment right above that when it is necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Unable to convert expiration date/time from bytes" was raised when parse some specific iso9660 images, eg:
https://mirrors.tuna.tsinghua.edu.cn/ubuntu-releases/xenial/ubuntu-16.04.7-server-amd64.iso