add maven checkstyle #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ou-taku14
suggested changes
Mar 22, 2020
| </build> | ||
|
|
||
| </project> | ||
| </project> |
senyer
reviewed
Mar 22, 2020
checkstyle-suppressions.xml
Outdated
| <suppress checks="SummaryJavadoc" files=".*" /> | ||
| <!-- suppress check for protobuf-generated files. --> | ||
| <!-- for windows separator--> | ||
| <suppress checks=".*" files="src[\\\\]main[\\\\]java[\\\\]com[\\\\]distkv[\\\\]rpc[\\\\]protobuf[\\\\]generated" /> |
Collaborator
There was a problem hiding this comment.
???
You should take a look at what this code does. What's the point of copying it here?
Contributor
|
I think we should enable CI at first, and then enable check-style. |
senyer
reviewed
Apr 9, 2020
| @@ -0,0 +1,22 @@ | |||
| name: distkv-cloud_build | |||
Collaborator
There was a problem hiding this comment.
I think this name can be optimized. The distkv cloud is recommended (note that %20 is required as a space placeholder for spaces to be recognized correctly)
| @@ -1,2 +1,5 @@ | |||
| # distkv-cloud | |||
| Distkv cloud | |||
| [](https://github.com/distkv-project/distkv/actions) | |||
Collaborator
There was a problem hiding this comment.
This is not the distkv cloud badge, but the distkv.
| # distkv-cloud | ||
| Distkv cloud | ||
| [](https://github.com/distkv-project/distkv/actions) | ||
| [](https://codebeat.co/projects/github-com-distkv-project-distkv-master) |
| @@ -0,0 +1,19 @@ | |||
| <!DOCTYPE suppressions PUBLIC | |||
| "-//Puppy Crawl//DTD Suppressions 1.1//EN" | |||
Collaborator
There was a problem hiding this comment.
The purpose of this file is to exclude files in the generated folder. There is no generated file for this project, so this file is not needed.
| </executions> | ||
| <configuration> | ||
| <configLocation>checkstyle.xml</configLocation> | ||
| <suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation> |
| </build> | ||
|
|
||
| </project> | ||
| </project> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.