Skip to content

Commit 363f198

Browse files
authored
chore: remove id column to give other columns more space (#1867)
Signed-off-by: Philip Miglinci <pmig@glasskube.com>
1 parent c69b676 commit 363f198

File tree

10 files changed

+4
-44
lines changed

10 files changed

+4
-44
lines changed

frontend/ui/src/app/applications/applications.component.html

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,6 @@
6060
<thead
6161
class="border-t border-gray-200 dark:border-gray-600 text-xs text-gray-700 uppercase bg-gray-100 dark:bg-gray-700 dark:text-gray-400">
6262
<tr>
63-
@if (fullVersion) {
64-
<th scope="col" class="p-4">Id</th>
65-
}
6663
<th scope="col" class="p-4">Application</th>
6764
<th scope="col" class="p-4">Type</th>
6865
<th scope="col" class="p-4">Versions</th>
@@ -75,11 +72,6 @@
7572
<tbody>
7673
@for (application of applications$ | async; track application.id) {
7774
<tr class="border-t border-gray-200 dark:border-gray-600 hover:bg-gray-100 dark:hover:bg-gray-700">
78-
@if (fullVersion) {
79-
<td class="px-4 py-3 font-medium text-gray-900 whitespace-nowrap dark:text-white">
80-
<app-uuid [uuid]="application.id!" />
81-
</td>
82-
}
8375
<td class="px-4 py-3 font-medium text-gray-900 whitespace-nowrap dark:text-white">
8476
<a [routerLink]="['/', 'applications', application.id]">
8577
<div class="flex items-center mr-3">

frontend/ui/src/app/applications/applications.component.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import {SecureImagePipe} from '../../util/secureImage';
2121
import {drawerFlyInOut} from '../animations/drawer';
2222
import {dropdownAnimation} from '../animations/dropdown';
2323
import {modalFlyInOut} from '../animations/modal';
24-
import {UuidComponent} from '../components/uuid';
2524
import {AutotrimDirective} from '../directives/autotrim.directive';
2625
import {
2726
PermissionsDirective,
@@ -42,7 +41,6 @@ import {ToastService} from '../services/toast.service';
4241
NgOptimizedImage,
4342
OverlayModule,
4443
AutotrimDirective,
45-
UuidComponent,
4644
RequireVendorDirective,
4745
RequireRoleDirective,
4846
PermissionsDirective,

frontend/ui/src/app/artifacts/artifact-licenses/artifact-licenses.component.html

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
<thead
4040
class="border-t border-gray-200 dark:border-gray-600 text-xs text-gray-700 uppercase bg-gray-100 dark:bg-gray-700 dark:text-gray-400">
4141
<tr>
42-
<th scope="col" class="p-4">Id</th>
4342
<th scope="col" class="p-4">Name</th>
4443
<th scope="col" class="p-4">Customer</th>
4544
<th scope="col" class="p-4">Artifact</th>
@@ -51,9 +50,6 @@
5150
<tbody>
5251
@for (license of licenses$ | async; track license.id) {
5352
<tr class="border-t border-gray-200 dark:border-gray-600 hover:bg-gray-100 dark:hover:bg-gray-700">
54-
<td class="px-4 py-3 font-medium text-gray-900 whitespace-nowrap dark:text-white">
55-
<app-uuid [uuid]="license.id!" />
56-
</td>
5753
<td class="px-4 py-3 font-medium text-gray-900 whitespace-nowrap dark:text-white">
5854
<div class="flex items-center mr-3">
5955
<span class="max-w-32 sm:max-w-64 lg:max-w-128 overflow-hidden text-ellipsis">

frontend/ui/src/app/artifacts/artifact-licenses/artifact-licenses.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import {filteredByFormControl} from '../../../util/filter';
1818
import {drawerFlyInOut} from '../../animations/drawer';
1919
import {dropdownAnimation} from '../../animations/dropdown';
2020
import {modalFlyInOut} from '../../animations/modal';
21-
import {UuidComponent} from '../../components/uuid';
2221
import {
2322
ArtifactLicense,
2423
ArtifactLicenseSelection,
@@ -33,7 +32,7 @@ import {EditArtifactLicenseComponent} from './edit-artifact-license.component';
3332

3433
@Component({
3534
selector: 'app-artifact-licenses',
36-
imports: [ReactiveFormsModule, AsyncPipe, FaIconComponent, UuidComponent, DatePipe, EditArtifactLicenseComponent],
35+
imports: [ReactiveFormsModule, AsyncPipe, FaIconComponent, DatePipe, EditArtifactLicenseComponent],
3736
templateUrl: './artifact-licenses.component.html',
3837
animations: [dropdownAnimation, drawerFlyInOut, modalFlyInOut],
3938
})

frontend/ui/src/app/components/customer-organizations/customer-organizations.component.html

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
<thead
4545
class="border-t border-gray-200 dark:border-gray-600 text-xs text-gray-700 uppercase bg-gray-100 dark:bg-gray-700 dark:text-gray-400">
4646
<tr>
47-
<th scope="col" class="p-4">Id</th>
4847
<th scope="col" class="p-4"></th>
4948
<th scope="col" class="p-4">Name</th>
5049
<th scope="col" class="p-4">Creation Date</th>
@@ -57,10 +56,7 @@
5756
<tbody>
5857
@for (customer of customerOrganizations(); track customer.id) {
5958
<tr class="border-t border-gray-200 dark:border-gray-600 hover:bg-gray-100 dark:hover:bg-gray-700">
60-
<td class="px-4 py-3 font-medium text-gray-900 whitespace-nowrap dark:text-white">
61-
<app-uuid [uuid]="customer.id" />
62-
</td>
63-
<td>
59+
<td class="pl-4">
6460
<button
6561
type="button"
6662
(click)="uploadImage(customer)"

frontend/ui/src/app/components/customer-organizations/customer-organizations.component.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import {OrganizationService} from '../../services/organization.service';
3030
import {DialogRef, OverlayService} from '../../services/overlay.service';
3131
import {ToastService} from '../../services/toast.service';
3232
import {QuotaLimitComponent} from '../quota-limit.component';
33-
import {UuidComponent} from '../uuid';
3433

3534
export const ALL_CUSTOMER_FEATURES: CustomerOrganizationFeature[] = ['deployment_targets', 'artifacts', 'alerts'];
3635

@@ -39,7 +38,6 @@ export const ALL_CUSTOMER_FEATURES: CustomerOrganizationFeature[] = ['deployment
3938
imports: [
4039
ReactiveFormsModule,
4140
FontAwesomeModule,
42-
UuidComponent,
4341
DatePipe,
4442
SecureImagePipe,
4543
AsyncPipe,

frontend/ui/src/app/components/users/users.component.html

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
<thead
4141
class="border-t border-gray-200 dark:border-gray-600 text-xs text-gray-700 uppercase bg-gray-100 dark:bg-gray-700 dark:text-gray-400">
4242
<tr>
43-
<th scope="col" class="p-4">Id</th>
4443
<th scope="col" class="p-4"></th>
4544
<th scope="col" class="p-4">Name</th>
4645
<th scope="col" class="p-4">E-Mail</th>
@@ -54,10 +53,7 @@
5453
<tbody>
5554
@for (user of users$ | async; track user.id) {
5655
<tr class="border-t border-gray-200 dark:border-gray-600 hover:bg-gray-100 dark:hover:bg-gray-700">
57-
<td class="px-4 py-3 font-medium text-gray-900 whitespace-nowrap dark:text-white">
58-
<app-uuid [uuid]="user.id!" />
59-
</td>
60-
<td>
56+
<td class="pl-4">
6157
@if (user.imageUrl) {
6258
<img
6359
(click)="uploadImage(user)"

frontend/ui/src/app/components/users/users.component.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ import {DialogRef, OverlayService} from '../../services/overlay.service';
3131
import {ToastService} from '../../services/toast.service';
3232
import {UsersService} from '../../services/users.service';
3333
import {QuotaLimitComponent} from '../quota-limit.component';
34-
import {UuidComponent} from '../uuid';
3534

3635
@Component({
3736
selector: 'app-users',
@@ -42,7 +41,6 @@ import {UuidComponent} from '../uuid';
4241
ReactiveFormsModule,
4342
RequireVendorDirective,
4443
AutotrimDirective,
45-
UuidComponent,
4644
SecureImagePipe,
4745
QuotaLimitComponent,
4846
],

frontend/ui/src/app/licenses/licenses.component.html

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
<thead
4040
class="border-t border-gray-200 dark:border-gray-600 text-xs text-gray-700 uppercase bg-gray-100 dark:bg-gray-700 dark:text-gray-400">
4141
<tr>
42-
<th scope="col" class="p-4">Id</th>
4342
<th scope="col" class="p-4">Name</th>
4443
<th scope="col" class="p-4">Customer</th>
4544
<th scope="col" class="p-4">Application</th>
@@ -51,9 +50,6 @@
5150
<tbody>
5251
@for (license of licenses$ | async; track license.id) {
5352
<tr class="border-t border-gray-200 dark:border-gray-600 hover:bg-gray-100 dark:hover:bg-gray-700">
54-
<td class="px-4 py-3 font-medium text-gray-900 whitespace-nowrap dark:text-white">
55-
<app-uuid [uuid]="license.id!" />
56-
</td>
5753
<td class="px-4 py-3 font-medium text-gray-900 whitespace-nowrap dark:text-white">
5854
<div class="flex items-center mr-3">
5955
<span class="max-w-32 sm:max-w-64 lg:max-w-128 overflow-hidden text-ellipsis">

frontend/ui/src/app/licenses/licenses.component.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import {filteredByFormControl} from '../../util/filter';
1818
import {drawerFlyInOut} from '../animations/drawer';
1919
import {dropdownAnimation} from '../animations/dropdown';
2020
import {modalFlyInOut} from '../animations/modal';
21-
import {UuidComponent} from '../components/uuid';
2221
import {AutotrimDirective} from '../directives/autotrim.directive';
2322
import {ApplicationsService} from '../services/applications.service';
2423
import {AuthService} from '../services/auth.service';
@@ -31,15 +30,7 @@ import {EditLicenseComponent} from './edit-license.component';
3130
@Component({
3231
selector: 'app-licenses',
3332
templateUrl: './licenses.component.html',
34-
imports: [
35-
AsyncPipe,
36-
AutotrimDirective,
37-
ReactiveFormsModule,
38-
FaIconComponent,
39-
UuidComponent,
40-
DatePipe,
41-
EditLicenseComponent,
42-
],
33+
imports: [AsyncPipe, AutotrimDirective, ReactiveFormsModule, FaIconComponent, DatePipe, EditLicenseComponent],
4334
animations: [dropdownAnimation, drawerFlyInOut, modalFlyInOut],
4435
})
4536
export class LicensesComponent {

0 commit comments

Comments
 (0)