Skip to content

Feature: Docker image healthcheck #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xBlaz3kx
Copy link
Contributor

Proposed changes

  • Added healthcheck to Dockerfile

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@vcastellm
Copy link
Member

This Dockerfile is just for development, can you elaborate on why do you need this?

@xBlaz3kx
Copy link
Contributor Author

Well in general its useful to know if the container is healthy or not. For example when running the raft cluster, one of the nodes could not be connected to the cluster, but in general that wouldnt terminate the container.

I guess the healthcheck does reflect that?

I'm also quite unsure why, by default, the docker entrypoint/cmd is just dkron command and not dkron agent --server ?
It would make it easier to run a cluster out of the box

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants