feat: allow users to dismiss divine login setup banner on profile#2214
Draft
rabble-claw wants to merge 3 commits intomainfrom
Draft
feat: allow users to dismiss divine login setup banner on profile#2214rabble-claw wants to merge 3 commits intomainfrom
rabble-claw wants to merge 3 commits intomainfrom
Conversation
Mobile PR Preview
|
Member
Member
|
I pulled this back up in the remaining queue. Main open question: should dismissal reset the next time we hit an expired-session state? As written, the dismissed banner appears to persist with no obvious reset path, so a future expired session can stay hidden. If product wants dismissal to apply only to the current expiry event, I think we need a reset trigger before merge. |
Member
|
@d-spurgin Can you please take a look at this in the context of your design work? You may already be addressing it? Thanks! cc @omartinma |
|
@NotThatKindOfDrLiz we have designs ready for this in the updated profile pages. Once we get the new designs into the dev cycle we can make this functionality available. Sound ok? |
47a1637 to
57282ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #2333
Summary
dismissed_divine_login_banner_<pubkey>)Testing
session expired banner can be dismissed and stays hidden