Skip to content

feat: allow users to dismiss divine login setup banner on profile#2214

Draft
rabble-claw wants to merge 3 commits intomainfrom
feat/dismiss-divine-login-banner
Draft

feat: allow users to dismiss divine login setup banner on profile#2214
rabble-claw wants to merge 3 commits intomainfrom
feat/dismiss-divine-login-banner

Conversation

@rabble-claw
Copy link
Copy Markdown
Contributor

@rabble-claw rabble-claw commented Mar 13, 2026

Closes #2333

Summary

  • add dismiss support to the expired divine login banner on own profile
  • persist dismissal in SharedPreferences per user (dismissed_divine_login_banner_<pubkey>)
  • keep existing sign-in behavior intact, but let users hide the prompt

Testing

  • flutter test test/widgets/profile/profile_header_widget_test.dart
    • added coverage: session expired banner can be dismissed and stays hidden

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 13, 2026

Mobile PR Preview

Property Value
Preview URL https://581f5b56.openvine-app.pages.dev
Pages project openvine-app
Preview branch pr-2214
PR branch feat/dismiss-divine-login-banner
Commit 57282ec

@rabble
Copy link
Copy Markdown
Member

rabble commented Mar 14, 2026

Screenshot 2026-03-14 at 10 52 59 AM

So it's showing the registration note thing at all.

@rabble
Copy link
Copy Markdown
Member

rabble commented Mar 16, 2026

I pulled this back up in the remaining queue. Main open question: should dismissal reset the next time we hit an expired-session state?

As written, the dismissed banner appears to persist with no obvious reset path, so a future expired session can stay hidden. If product wants dismissal to apply only to the current expiry event, I think we need a reset trigger before merge.

@NotThatKindOfDrLiz
Copy link
Copy Markdown
Member

@d-spurgin Can you please take a look at this in the context of your design work? You may already be addressing it? Thanks! cc @omartinma

@NotThatKindOfDrLiz NotThatKindOfDrLiz marked this pull request as draft March 18, 2026 16:52
@d-spurgin
Copy link
Copy Markdown

@NotThatKindOfDrLiz we have designs ready for this in the updated profile pages. Once we get the new designs into the dev cycle we can make this functionality available. Sound ok?

@rabble rabble force-pushed the feat/dismiss-divine-login-banner branch from 47a1637 to 57282ec Compare March 22, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

task: track dismissible divine login banner on profile

4 participants