fix: Add missing {S20,U20}{LE,BE} (20 bits for 4 bytes align) #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi, I'm curious if this is a format that you've found in the wild and need to support or it's more about completeness? Also it seems this causes the test to fail, can you correct it and resubmit? |
Contributor
Author
|
Basically it's about completeness since https://github.com/diwic/alsa-sys/blob/2fa68345010523d76e66c5f2377324fbfd6d124d/src/generated.rs#L964-L971 are only four formats that this crate does not provide. Also I'm writing an application to match the fields for completeness and found that there are no these four fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.