Skip to content

Conversation

@fsbraun
Copy link
Member

@fsbraun fsbraun commented Nov 24, 2025

Description

Prepare a patch release that includes built frontend bundles in the distributed package.

Enhancements:

  • Add compiled filer-base and admin file widget JavaScript bundles to the static distribution.
  • Include a licenses manifest for bundled frontend assets.
  • Bump the package version from 3.4.0 to 3.4.1 for the new distribution contents.

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Prepare a patch release that ships precompiled frontend bundles with the package and updates the package version accordingly.

Enhancements:

  • Include compiled filer-base and admin file widget JavaScript bundles in the static assets distribution to avoid requiring consumers to build them.

Build:

  • Update package version from 3.4.0 to 3.4.1 to reflect the new distribution contents.
  • Add a licenses manifest file for bundled frontend assets in the distributed static files.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 24, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds prebuilt JavaScript bundles and a licenses manifest to the static distribution and bumps the filer package version for a patch release.

Flow diagram for building and distributing new frontend bundles

flowchart TD
  A["Frontend source code (focal point, admin widget, etc.)"] --> B["Bundler/transpiler (e.g., webpack)"]
  B --> C["Output: filer-base.bundle.js"]
  B --> D["Output: admin-file-widget.bundle.js"]
  B --> E["Generated LICENSES.txt for bundled JS"]

  C --> F["Add to repo under filer/static/filer/js/dist/"]
  D --> F["Add to repo under filer/static/filer/js/dist/"]
  E --> F["Add to repo under filer/static/filer/js/dist/"]

  F --> G["Update filer/__version__ to 3.4.1"]
  G --> H["Build Python sdist/wheel including dist JS and licenses"]
  H --> I["Publish filer 3.4.1 to package index"]
  I --> J["pip install filer==3.4.1 in Django project"]
  J --> K["Static files available for collectstatic and admin UI"]
Loading

File-Level Changes

Change Details Files
Bump package version for new distribution contents.
  • Update the version string to the new patch version to reflect the added assets.
filer/__init__.py
Add compiled frontend bundles to the distributed static assets.
  • Check in the compiled filer-base JavaScript bundle used for focal point selection and related UI behavior.
  • Check in the compiled admin file widget JavaScript bundle, including its Core-JS and Mediator.js dependencies for admin UI functionality.
filer/static/filer/js/dist/filer-base.bundle.js
filer/static/filer/js/dist/admin-file-widget.bundle.js
Prepare licensing information for bundled frontend assets.
  • Add an empty or placeholder LICENSES.txt file alongside the JS bundles to list third-party licenses for bundled code. The reviewer should confirm this will be populated appropriately in the release process.
filer/static/filer/js/dist/LICENSES.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@fsbraun fsbraun merged commit e655d8b into master Nov 24, 2025
18 of 86 checks passed
@fsbraun fsbraun deleted the fix/add-bundles-to-dist branch November 24, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants