Skip to content

Conversation

mrbazzan
Copy link
Contributor

Description

  • remove unused base.txt file
  • switch to pytest
  • update test requirements

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@mrbazzan
Copy link
Contributor Author

@fsbraun
I wanted to omit the coverage for djangocms/migrations/* but
some of the migration files were manually written e.g 0006_migrate_to_filer.py.
How do I find the test(file|function) which "covers" this migration?

@fsbraun
Copy link
Member

fsbraun commented Feb 26, 2025

I doubt there is any. It just runs (if it is covered).

Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I don't wory about the missing migration coverage.

@fsbraun fsbraun merged commit b45bdd1 into django-cms:master Feb 27, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants