chore: Update test matrix #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added changelog entry for version 0.7.5 with a fix for the Stories config form.
Contributor
Reviewer's GuideUpdates project support matrix and tooling for newer Python and Django versions while dropping Python 3.9, and adds a defensive stub for optional django-meta integration. Updated class diagram for optional ModelMeta stubclassDiagram
class ModelMeta {
+as_meta()
+build_absolute_uri(url)
}
class DjangoAppsRegistry
DjangoAppsRegistry <.. ModelMeta : conditionally_imports_or_defines
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The conditional import of ModelMeta using apps.is_installed() happens at import time and depends on the Django app registry being ready; consider switching to a simple try/except ImportError-based import to avoid potential issues during early imports or non-standard initialization contexts.
- For the ModelMeta stub, you may want to mirror the real class interface more closely (e.g., method signatures, return types) or clearly separate it (e.g., via a mixin or helper) so that any code using ModelMeta behaves consistently whether or not django-meta is installed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The conditional import of ModelMeta using apps.is_installed() happens at import time and depends on the Django app registry being ready; consider switching to a simple try/except ImportError-based import to avoid potential issues during early imports or non-standard initialization contexts.
- For the ModelMeta stub, you may want to mirror the real class interface more closely (e.g., method signatures, return types) or clearly separate it (e.g., via a mixin or helper) so that any code using ModelMeta behaves consistently whether or not django-meta is installed.
## Individual Comments
### Comment 1
<location> `CHANGELOG.rst:8` </location>
<code_context>
+0.7.5 (2025-11-21)
+------------------
+
+* fix: Stories config form instead of current values always presented inital values
+* fix: Allow to run without django-meta installed
+
</code_context>
<issue_to_address>
**suggestion (typo):** Fix the typo in "inital" and consider reordering the sentence for clarity.
Suggested wording: "Stories config form always presented initial values instead of current values," which makes the intent clearer.
```suggestion
* fix: Stories config form always presented initial values instead of current values
```
</issue_to_address>
### Comment 2
<location> `CHANGELOG.rst:9` </location>
<code_context>
+------------------
+
+* fix: Stories config form instead of current values always presented inital values
+* fix: Allow to run without django-meta installed
+
0.7.4 (2025-09-17)
</code_context>
<issue_to_address>
**suggestion (typo):** Tighten the grammar in "Allow to run" for better readability.
The phrase "Allow to run" is grammatically awkward. Consider rephrasing to something like "Allow running without django-meta installed" or "Allow the package/app to run without django-meta installed."
```suggestion
* fix: Allow running without django-meta installed
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| ------------------ | ||
|
|
||
| * fix: Stories config form instead of current values always presented initial values | ||
| * fix: Stories config form instead of current values always presented inital values |
Contributor
There was a problem hiding this comment.
suggestion (typo): Fix the typo in "inital" and consider reordering the sentence for clarity.
Suggested wording: "Stories config form always presented initial values instead of current values," which makes the intent clearer.
Suggested change
| * fix: Stories config form instead of current values always presented inital values | |
| * fix: Stories config form always presented initial values instead of current values |
|
|
||
| * fix: Stories config form instead of current values always presented initial values | ||
| * fix: Stories config form instead of current values always presented inital values | ||
| * fix: Allow to run without django-meta installed |
Contributor
There was a problem hiding this comment.
suggestion (typo): Tighten the grammar in "Allow to run" for better readability.
The phrase "Allow to run" is grammatically awkward. Consider rephrasing to something like "Allow running without django-meta installed" or "Allow the package/app to run without django-meta installed."
Suggested change
| * fix: Allow to run without django-meta installed | |
| * fix: Allow running without django-meta installed |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
- Coverage 90.02% 89.77% -0.26%
==========================================
Files 23 23
Lines 2116 2122 +6
Branches 239 240 +1
==========================================
Hits 1905 1905
- Misses 128 133 +5
- Partials 83 84 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Raise the supported Python and Django versions, adjust tooling accordingly, and add a fallback for optional metadata integration.
New Features:
Enhancements:
Build:
CI:
Tests:
Chores: