-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type hints: toolbar/middleware #1848
base: main
Are you sure you want to change the base?
Type hints: toolbar/middleware #1848
Conversation
I haven't touched on the |
I'm not quite sure how to resolve this lint error. Can anyone give me a hint? |
@leandrodesouzadev The automatically generated documentation for panels (https://django-debug-toolbar.readthedocs.io/en/latest/panels.html#debug_toolbar.panels.Panel) will contain a reference to your new Something like this fixes it:
I'm not sure if that's what we want. Maybe there's a different way to specify the type which doesn't require the |
Will definitely take a look into it |
@leandrodesouzadev 👋 I wanted to check in to see how this is coming along. Did you want to keep moving forward with it? |
I can pick this up if want to continue on this path. If @leandrodesouzadev okay with it. |
Please feel free to pick up this work @salty-ivy ! The comment is more than 15 months old. |
Description
This PR adds type hints to the
middleware
andtoolbar
modulesFixes #1705
Checklist:
docs/changes.rst
.