-
Notifications
You must be signed in to change notification settings - Fork 1.1k
remove requirement_dev.txt from project #2277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f5cec10 to
b3bab6b
Compare
tim-schilling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for iterating on this. I still have some open questions unfortunately. I'm sorry for the slow responses.
|
Hey @tim-schilling , Currently I have some thoughts in my mind.
I'm happy to iterate as per the feedback. and I'm happy answer/discuss questions. Thank you. |
b3bab6b to
9191aea
Compare
| .. code-block:: bash | ||
| pip install -r requirements_dev.txt | ||
| pip install --group dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| pip install --group dev | |
| pip install --group dev --group docs |
This is referring to the documentation dependencies. I suspect we need to change all the references? Or have the dev group also include the docs group.
tim-schilling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a different workflow than I'm used to, though I think it's close to a mergeable state. @matthiask or I will need to check on the readthedocs integration after this gets merged. It's probably a good idea regardless since it's been a while since I've looked at that.
I'd like to get opinions from @django-commons/django-debug-toolbar on whether this is +1, 0 or -1 type thing. For me, I'm very used to pip install -r requirements_dev.txt. I suspect I will get tripped up by this change for a while. That said, I'm a 0 on it. I like the docs dependency group for read the docs.
since we are using pyproject.toml depending on extra file for dependency is redundant. we should use the power of pyproject.toml to take care of it.
according PEP 735 we can use dependency groups which is more convenient.